search

rhevm-qe-automation / pytest_jira

py.test plugin to integrate with JIRA
GNU General Public License v2.0
29 stars 25 forks source link

Add option to return jira issue metadata (Issue #94) #107

Closed gs202 closed 5 years ago

gs202 commented 5 years ago

Adding option to return jira issue model (with metadata) instead of boolean result (--jira-return-issue) issue #94 The issue type that will be returned is JiraIssue model using pydantic, with currently the MVP fields.

Using jira (https://pypi.org/project/jira/) will require changing the connection method, also the returned fields (metadata) has nothing more than when using request call - so i thought it will not add any value.

codecov-io commented 5 years ago

Codecov Report

Merging #107 into master will decrease coverage by 0.19%. The diff coverage is 92.85%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #107     +/-   ##
=========================================
- Coverage   95.08%   94.89%   -0.2%     
=========================================
  Files           1        1             
  Lines         224      235     +11     
=========================================
+ Hits          213      223     +10     
- Misses         11       12      +1
Impacted Files Coverage Δ
pytest_jira.py 94.89% <92.85%> (-0.2%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8123759...014b2c8. Read the comment docs.

gs202 commented 5 years ago

Thank you for your contribution, it looks like that pydantic lib is not really available for py3.5.

I don't like idea of loosing compatibility with supported version of python. You might consider to restrict this feature to be enabled only for >py3.5 ... or something like that.

Will work on that