Removed Jira 3rd party dep

[liiight]

Since the JIRA lib is totally overkill for this project (and since it was causing me issues) I removed it.

[lukas-bednar]

@liiight and requirements-pytest2.txt :-)

[liiight]

what's that one for?

[lukas-bednar]

what's that one for?

for testing with pytest versioin 2 for backward compatibility

[liiight]

Not sure why all the tests fail like that, they pass locally for me

[lukas-bednar]

Not sure why all the tests fail like that, they pass locally for me

Try to remove .tox directory and run it again. Thanks for this change, we had that TODO there for long time 👍 ... I will review your change later today.

[liiight]

I have zero experience with Tox. How can I debug test execution?

[lukas-bednar]

I have zero experience with Tox. How can I debug test execution?

Just run py.test command by hand, but make sure that you have jira_plugin installed.

py.test -p pytester tests

I would use virtualenv, and execute following inside of repository

virtualenv ENV
source ENV/bin/activate
pip install -I .
py.test -p pytester tests/

[liiight]

So in order to debug the plugin code I have to have the plugin installed? What?

[liiight]

fixture 'testdir' not found where does this fixture supposed to come from?

[lukas-bednar]

So in order to debug the plugin code I have to have the plugin installed? What?

Not necessary but that what I do, it is very easy with virtualenv.

[lukas-bednar]

fixture 'testdir' not found where does this fixture supposed to come from?

directly from pytest ... that is reason why -p pytester parameter is there ... https://docs.pytest.org/en/latest/writing_plugins.html#testing-plugins

[codecov-io]

Codecov Report

Merging #72 into master will decrease coverage by 0.47%. The diff coverage is 95.65%.

@@            Coverage Diff             @@
##           master      #72      +/-   ##
==========================================
- Coverage   98.73%   98.25%   -0.48%     
==========================================
  Files           1        1              
  Lines         158      172      +14     
==========================================
+ Hits          156      169      +13     
- Misses          2        3       +1

Impacted Files	Coverage Δ
pytest_jira.py	98.25% <95.65%> (-0.48%)	:arrow_down:

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f29c9c7...96cf6a0. Read the comment docs.

[liiight]

well i need a private jira server to use in the tests in order to raise coverage. got any suggestions?

[lukas-bednar]

well i need a private jira server to use in the tests in order to raise coverage. got any suggestions

it is just 0.5% decrease, it is ok ...

I will review it later today, thanks!

[liiight]

Np. Note that the ssl verify option does nothing now, I kept it in for backwards compatability. Probably should just raise a warning though

[lukas-bednar]

Np. Note that the ssl verify option does nothing now, I kept it in for backwards compatability. Probably should just raise a warning though

good point, please open issue for that, in order to don't miss it in next release. Thanks.