rhevm-qe-automation / pytest_jira

py.test plugin to integrate with JIRA
GNU General Public License v2.0
29 stars 25 forks source link

Added docstring to `jira_issue` fixture #79

Closed liiight closed 7 years ago

liiight commented 7 years ago

This adds data when running pytest --fixtures:

-------------------------------------------------------------------------------------------------- fixtures defined from pytest_jira ---------------------------------------------------------------------------------------------------
jira_issue
    /Users/orcarmi/stronghold-py/lib/python3.6/site-packages/pytest_jira.py:450: no docstring available
liiight commented 7 years ago

I fucked up my fork from a botched rebase, if the dirty commit history is problematic let me know and ill recreate the branch (although you should be able to squash the commit on the merge and ignore this shit anyway).

codecov-io commented 7 years ago

Codecov Report

Merging #79 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #79   +/-   ##
=======================================
  Coverage   98.34%   98.34%           
=======================================
  Files           1        1           
  Lines         181      181           
=======================================
  Hits          178      178           
  Misses          3        3
Impacted Files Coverage Δ
pytest_jira.py 98.34% <ø> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 628f873...d028b60. Read the comment docs.

liiight commented 7 years ago

I think this enforcement is way too strict. pep8 is supposed be a style guide, hard limiting to 72 chars per line just too strict, other project relax it to 100 or even 120 chars.

lukas-bednar commented 7 years ago

I think this enforcement is way too strict. pep8 is supposed be a style guide, hard limiting to 72 chars per line just too strict, other project relax it to 100 or even 120 chars.

AFAIR default should be 79. I think going with defaults could not be so strict ;-) It is just a matter of each project, how it is set there.

Thanks for PR!

liiight commented 7 years ago

For docstrings it's 72 AFAIK, but whatever :-)