search

rhevm-qe-automation / pytest_jira

py.test plugin to integrate with JIRA
GNU General Public License v2.0
29 stars 25 forks source link

Always skip issue when run is False #82

Closed liiight closed 7 years ago

liiight commented 7 years ago

if run was set to False the test was always skipped

codecov-io commented 7 years ago

Codecov Report

Merging #82 into master will not change coverage. The diff coverage is 66.66%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #82   +/-   ##
=======================================
  Coverage   98.34%   98.34%           
=======================================
  Files           1        1           
  Lines         181      181           
=======================================
  Hits          178      178           
  Misses          3        3
Impacted Files Coverage Δ
pytest_jira.py 98.34% <66.66%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 22bf4e8...36efeef. Read the comment docs.

liiight commented 7 years ago

right about the issue, wrong about the fix 😄 since the resolved_status generator was consumed after the first call, self.is_issue_resolved(issue_id) always returned False. A negative test to run=False catches this.

liiight commented 7 years ago

should i care about that coverage drop?

lukas-bednar commented 7 years ago

should i care about that coverage drop?

no, that relevant if-branch is not covered currently anyway. https://codecov.io/gh/rhevm-qe-automation/pytest_jira/compare/22bf4e8c4a53f39b2f9fb56a72128afee669c10b...36efeef380e240046269213f6ed938c7a4dd7c8d/diff#D2-420

lukas-bednar commented 7 years ago

Thank you!

liiight commented 7 years ago

np, glad to help.