Closed liiight closed 6 years ago
In my opinion I think the best would skip loading plugin in that case.
but on other hand what if jira server go down during test execution?
I am not really confident with suggestions here, because since you expect some plugin to do some job for you and if it can not it should give you some feedback that something goes differently than expected ...
The way I see it there are several flows on connection error:
We can have a flag/config option that will let the user select which one they prefer. Personnaly I'd go for no. 3.
WDYT?
I would go with backward compatibility, so by default no 1 as a default, and I also think that no 3 & 4 find use case too.
Cool, I'll put up a PR
I think we are covered here, I am closing that. If you miss something there feel free reopen it!
Currently pytest crashes on jira connection error since it doesn't catch request exceptions. This has an undesirable effect of making builds that run pytest fail which cause false positives.
I propose passing a flag that will enable either gracefully not load the plugin, or alternatively skip the test with a successful exit code.
Thoughts?