Added keyword option "skipif" to disable issue marker

[mjuuti-tns]

Add optional keyword argument 'condition' to jira markers to be able to disable marker if conditions are not met for example if Jira issue is specific only for one environment but does not affect others.

[liiight]

I like this idea, but I would call the keyword skipif to match pytest's terminology.

[mjuuti-tns]

Sure, I'll do changes tomorrow (it's midnight here). Just one verification: skipif=True-like object (or Callable which returns True-like object) would

• skip the test, e.g. enable jira() line, or
• skip the marker line?

I'd believe latter but just in case :)

[liiight]

That's a great question... I'm actually leaning towards the former, as in apply the marker if the condition is true.

[lukas-bednar]

I was consider following workflow: lets say that in case skipif is passed to marker, then it expects to get function which takes issue argument as a parameter. in this case plugin calls passed function with appropriate issue as an argument, and depends on result the test-cases will be skipped (returned true) or executed (returned fasle).

Does it make sense, fit to your use-case ?

[codecov-io]

Codecov Report

Merging #89 into master will increase coverage by 0.09%. The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #89      +/-   ##
==========================================
+ Coverage   97.82%   97.91%   +0.09%     
==========================================
  Files           1        1              
  Lines         184      192       +8     
==========================================
+ Hits          180      188       +8     
  Misses          4        4

Impacted Files	Coverage Δ
pytest_jira.py	97.91% <100%> (+0.09%)	:arrow_up:

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d60d3e9...80d435c. Read the comment docs.

[mjuuti-tns]

Sure; my current use case only needs boolean, e.g. jira("ABC-1234", skipif=(Config.Value==Constant.Value)); Information which is available for python process but most likely is not in JIRA.

I added lambda handling but it came with some drawbacks:

• JiraConnection has to be passed to JiraMarkerReporter as parameter for lambdas to work. Default value is None for backwards compatibility (subclassing).
• If lambda is used JIRA will be queried twice for each issue ID; first for skipif and again when checking if ticket is open
• If JIRA connection fails there is no handling for it. This probably could be done using default strategy, in case of exception set skipif value (for the JIRA ID) True if strategy is 'open' ?

[lukas-bednar]

I am giving some time to @liiight if he wants to share his opinion here, since he has expressed interest in this feature :-)

[liiight]

Looks great to me, thanks for considering me

[lukas-bednar]

@mjuuti-tns Thank you.