liiight commented 6 years ago

This PR adds the ability to select how to handle connection errors to Jira, wether it's authentication or any other connection issue.

Changes:

Jira connection is now lazy loaded, called to only when the first marked issue is asked for. This has the added bonus of speeding up the test session startup time and actually not do anything if no collected tests actually use the jira plugin (via a marker or a fixture).
A new --jira-error-strategy flag has been added, with option to set to either strict (default), skip or ignore.
strict follows the current behaviour, raising an error on any exception, crashing the test session.
skip skip the current test that uses the fixture/marker.
ignore just disregard the marker completely, running the test as if the plugin was not loaded/issue was resolved.
Jira hooks now handles requests.RequestException, applied logic there.
Applied same logic to jira_issue fixture as the internal logic is based solely around markers. This is not ideal and there should be only one centralized logic, but that would probably require redesigning the entire plugin

codecov-io commented 6 years ago

Codecov Report

Merging #95 into master will increase coverage by 0.22%. The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #95      +/-   ##
==========================================
+ Coverage   97.83%   98.06%   +0.22%     
==========================================
  Files           1        1              
  Lines         185      207      +22     
==========================================
+ Hits          181      203      +22     
  Misses          4        4

Impacted Files	Coverage Δ
pytest_jira.py	`98.06% <100%> (+0.22%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 439eb3e...b85a6bc. Read the comment docs.

liiight commented 6 years ago

Sorry about the branch history, I can squash it if you'd like.

lukas-bednar commented 6 years ago

Sorry about the branch history, I can squash it if you'd like.

Feel free to squash it by yourself. If you leave it as it is, I will squash it upon merge ;-) ...

liiight commented 6 years ago

All comments addressed

lukas-bednar commented 6 years ago

Fixes #84

lukas-bednar commented 6 years ago

Looks great, waiting for tests to finish ...

liiight commented 6 years ago

Cool, now off to make JiraIssue.

rhevm-qe-automation / pytest_jira

Handle connection errors #95

Changes:

Codecov Report