search

rhevm-qe-automation / pytest_jira

py.test plugin to integrate with JIRA
GNU General Public License v2.0
29 stars 25 forks source link

Enable using envar for password #97

Closed liiight closed 5 years ago

liiight commented 5 years ago

This will look for PYTEST_JIRA_PASSWORD envvar and use it if exist (take precedence over config password).

lukas-bednar commented 5 years ago

It looks great! Test is failing because of #96 ... I will fix that so we can pass ci for this pr.

liiight commented 5 years ago

Cool. I don't know why my git history is fucked up like that, I swear I rebased. I'll reclone after this is merged...

lukas-bednar commented 5 years ago

@liiight could you please rebase your change ? Travis should pass now!

codecov-io commented 5 years ago

Codecov Report

Merging #97 into master will increase coverage by <.01%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #97      +/-   ##
==========================================
+ Coverage   98.19%   98.19%   +<.01%     
==========================================
  Files           1        1              
  Lines         221      222       +1     
==========================================
+ Hits          217      218       +1     
  Misses          4        4
Impacted Files Coverage Δ
pytest_jira.py 98.19% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d2c2b50...52fe460. Read the comment docs.

lukas-bednar commented 5 years ago

Thank you !

liiight commented 5 years ago

Sure thing. Thanks for this plugin 👍 Note that I pinged you about #94