rhgndf / pe

0 stars 0 forks source link

Multiple pipe chars are not handled well #3

Open rhgndf opened 3 years ago

rhgndf commented 3 years ago

Using the command add n/Bob Ang p/88765432 e/bobhnd@example.com a/John street, block 123, #01-01 b/1998 07 10 c/BMW+Coupe||2030 01 01 c/Porsche+SUV||2030 01 01 cp/MercedesBenz+SUV It shows the errors as CarBrand+CarType not empty, which is confusing.

nus-pe-bot commented 3 years ago

Team's Response

The multiple pipe characters are not part of the syntax.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

[x] I disagree

Reason for disagreement: However, the user has clearly entered a non-empty CarBrand. Command parsing should instead take the items before the first | and after the last |. Then again, it can be confusing for someone who has a typo in such a long command.