rhgrant10 / berserk

Python client for the lichess API
https://berserk.readthedocs.io
Other
141 stars 36 forks source link

Updated Tournaments functionality #25

Open ZackClements opened 3 years ago

ZackClements commented 3 years ago

Modified: Tournaments.create() -> Tournaments.create_arena() Tournaments.export_games() -> Tournaments.export_arena_games() Added: Tournaments.create_swiss() Tournaments.export_swiss_games() Tournaments.tournaments_by_user() Tournaments.arena_by_team() Tournaments.swiss_by_team()

codecov-io commented 3 years ago

Codecov Report

Merging #25 (86ffcfe) into master (1b000a4) will decrease coverage by 1.69%. The diff coverage is 25.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #25      +/-   ##
==========================================
- Coverage   70.04%   68.34%   -1.70%     
==========================================
  Files           8        8              
  Lines         671      695      +24     
==========================================
+ Hits          470      475       +5     
- Misses        201      220      +19     
Impacted Files Coverage Δ
berserk/clients.py 32.65% <25.00%> (-1.06%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1b000a4...86ffcfe. Read the comment docs.

tranq2 commented 3 years ago

This functionality will be very useful.

Is the code coverage coming up because an existing method has been changed i.e. Tournaments.create() -> Tournaments.create_arena() Tournaments.export_games() -> Tournaments.export_arena_games()

are the existing methods available for backwards compatibility or have they been removed? is that causing a code coverage issue. Just a thought I am not familiar enough with how this works.

ZackClements commented 3 years ago

This functionality will be very useful.

Is the code coverage coming up because an existing method has been changed i.e. Tournaments.create() -> Tournaments.create_arena() Tournaments.export_games() -> Tournaments.export_arena_games()

are the existing methods available for backwards compatibility or have they been removed? is that causing a code coverage issue. Just a thought I am not familiar enough with how this works.

The existing methods were removed, however backwards compatibility was something I had overlooked when originally modifying the methods. Thanks for bringing it to my attention, will add to the list of items to fix before committing again.

I need to do more research into testing with CodeCov. There's a few things I'm confused about, mainly how / why clients is only at 32% coverage and if this has anything to do with there being a lack of a test file for clients. If anyone reading is more knowledgeable here please let me know.