search

rhgrant10 / berserk

Python client for the lichess API
https://berserk.readthedocs.io
Other
142 stars 36 forks source link

Add lot of functions to API #38

Closed Virinas-code closed 2 years ago

Virinas-code commented 3 years ago

Check out berserk/todo.md

rhgrant10 commented 2 years ago

wow thank you @Virinas-code! this is fantastic. would you mind rebasing? I've migrated off of travis-ci and replaced it with a github action that should trigger on this PR when you rebase. if you can resolve any test/lint issues that come up I can get this merged and cut a new release

Virinas-code commented 2 years ago

OK! Thank you for supporting this PR! I will update this after 1 or 2 days, I have a lot of work. Thank you!

Virinas-code commented 2 years ago

Ready to merge.

codecov[bot] commented 2 years ago

Codecov Report

Merging #38 (4fbbee6) into master (c7b05a8) will decrease coverage by 6.44%. The diff coverage is 22.99%.

@@            Coverage Diff             @@
##           master      #38      +/-   ##
==========================================
- Coverage   70.44%   63.99%   -6.45%     
==========================================
  Files           8        8              
  Lines         680      811     +131     
==========================================
+ Hits          479      519      +40     
- Misses        201      292      +91
Impacted Files Coverage Δ
berserk/exceptions.py 93.18% <ø> (ø)
berserk/formats.py 89.65% <ø> (ø)
berserk/utils.py 89.58% <ø> (ø)
berserk/clients.py 32.83% <21.85%> (-1.12%) :arrow_down:
berserk/models.py 91.83% <100.00%> (ø)
berserk/session.py 87.87% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c7b05a8...4fbbee6. Read the comment docs.

rhgrant10 commented 2 years ago

@Virinas-code I didn't know I had to approve the github action workflow to run on this PR, but I've done that now 👍 Thanks for rebasing - the new workflow checks show it builds and the tests pass (I'm not worried about the codecov one for now btw)

Couple of things still needed here:

Virinas-code commented 2 years ago

OK, all problems fixed.