Separate properties and classes that aren't part of AS2 into Extensions area

rhiaro / as2-reports

Script for generating a summary of AS2 implementation reports

3 stars 3 forks source link

Separate properties and classes that aren't part of AS2 into Extensions area #3

Open evanp opened 7 years ago

evanp commented 7 years ago

Move red stuff to the bottom.

rhiaro commented 7 years ago

I already did some time ago (like a week?). I'm not sure why you're still seeing them. @dissolve, did you pull the latest code before you ran it..?

rhiaro commented 7 years ago

WELP I forgot to commit that change.

rhiaro commented 7 years ago

I have now done so

dissolve commented 7 years ago

@rhiaro we agreed today to keep them in the report summary but move them to the bottom. Your code just removes them. Please re-open this issue. See https://ben.thatmustbe.me/static/reports.html for output of my PR example

rhiaro commented 7 years ago

Okay, can you make your PR again over my updates?

dissolve commented 7 years ago

Done, I left out the part of adding a legend to reader knows what P, C, and PC mean, (though I would recommend that) and left your coloring preference for empty fields