fix: clean up compiler warnings

rhinestonewtf / modulekit

Development Kit for building Smart Account Modules

https://docs.rhinestone.wtf/modulekit/

45 stars 26 forks source link

fix: clean up compiler warnings #106

Closed mehtaculous closed 2 months ago

mehtaculous commented 2 months ago

Majority of these compiler warnings are for unused function parameters and local variables

Simple solution was to just comment them out for now

Also updated foundry.toml to ignore warnings from node_moules and integrations directories

kopy-kat commented 2 months ago

looks good, thanks! could you please run pnpm lint:sol to make sure the ci passes

mehtaculous commented 2 months ago

some additional fixes after running the linter:

solhint requests that commas come before the actual parameter name when it is commented out (I personally find this to be a bit weird but can leave it as is or simply just remove the commented out name to avoid any possible confusion)
updated 2 requires to custom reverts => this also should save some gas
removed a few unused imports from integration contracts
updated solhint.json by setting no-global-import to off

mehtaculous commented 2 months ago

also updated the README to include the lint command

kopy-kat commented 2 months ago

great thank you, could you also just fix the conflicts (the ExtensibleFallbackHandler.sol) was actually just removed since it is an outdated component

mehtaculous commented 2 months ago

fixed the merge conflicts and made some additional fixes after running the linter due to the latest changes to main. should be good to go but may want to take a final look through before merging

kopy-kat commented 2 months ago

lgtm and thanks again