search

rhinestonewtf / modulekit

Development Kit for building Smart Account Modules
https://docs.rhinestone.wtf/modulekit/
53 stars 29 forks source link

Enhancement: split gas strings using _ to make more readable (eg 1_000_000) #78

Closed kopy-kat closed 5 months ago

kopy-kat commented 6 months ago

Instead of 

{
  "Calldata": {
    "Arbitrum": "6504 gas",
    "OP-Stack": "8859 gas"
  },
  "Phases": {
    "Creation": "187170 gas",
    "Execution": "37054 gas",
    "Validation": "35980 gas"
  },
  "Total": "2550948 gas"
}

it should return 

{
  "Calldata": {
    "Arbitrum": "6_504 gas",
    "OP-Stack": "8_859 gas"
  },
  "Phases": {
    "Creation": "187_170 gas",
    "Execution": "37_054 gas",
    "Validation": "35_980 gas"
  },
  "Total": "2_550_948 gas"
}
kopy-kat commented 5 months ago

closed by https://github.com/rhinestonewtf/modulekit/pull/88 thanks to @kanthgithub