rhino-linux / os

Rhino Linux ISO Builder.
GNU General Public License v3.0
53 stars 10 forks source link

Feat: Ditch calamares in favour of a new installer. #69

Closed ajstrongdev closed 2 days ago

ajstrongdev commented 11 months ago

A proposal brought about by both @oklopfer and @ajstrongdev for ditching Calamares in favour of a new installer for 2024.1.

Why ditch calamares:

ajstrongdev commented 11 months ago

We could use https://gitlab.gnome.org/p3732/os-installer as a solid base to work from if we are creating a GTK4 based installer.

If we wish to have a more macOS-like installer, we could always look at forking: https://github.com/elementary/installer

Elsie19 commented 11 months ago

I disagree, calamares is well established and the de facto standard for linux installers, and it being "ugly" is entirely our fault:

Archcraft

NitruxOS

to give a couple examples.

ajstrongdev commented 11 months ago

I disagree, calamares is well established, and it being "ugly" is entirely our fault:

I completely agree with that to be honest. But I do not disagree with the first points raised. We use a GTK based environment, we should aim to keep our installer GTK-based as well.

Nitrux clearly customised calamares correctly though.

Elsie19 commented 11 months ago

You also mention bloat, but have you actually measured the installable difference?

Elsie19 commented 11 months ago

We've determined the bloat is about 16MB uncompressed, so it would be further compressed when the ISO is packed.

ajstrongdev commented 11 months ago

We've determined the bloat is about 16MB uncompressed, so it would be further compressed when the ISO is packed.

It's pretty evident your math is wrong on that. Are you literally only checking Kvantum instead of Calamares + all the QT dependencies?

Elsie19 commented 11 months ago

That's only kvantum, I am checking Calamares right now.

Elsie19 commented 11 months ago

200MB.

oklopfer commented 11 months ago

elsie been lying on us this whole time its approx 360MB on the ISOs, not including kvantum regardless, I dont want Qt defaults in our GTK enviro.

maki406 commented 11 months ago

🐱

holysses commented 11 months ago

I agree with Elsie calamares is long established it works just change the themeing if you do not like it

Elsie19 commented 11 months ago

elsie been lying on us this whole time its approx 360MB on the ISOs, not including kvantum regardless, I dont want Qt defaults in our GTK enviro.

I checked in a docker container with XFCE already installed to get a good idea of what adding calamares would cost, so I didn't lie, it was just not the right number that the ISO actually uses.

ajstrongdev commented 11 months ago

The community seems pretty clear in their wants and needs; developing an entirely new installer is a large undertaking and would divert a lot of resources when we could just make calamares more pretty.

The main concern is we can decrease the disk image size and not have any QT spill over in a GTK based environment.

Elsie19 commented 11 months ago

As I've said in channels but I'll put it here as well, we can use apt install --no-install-recommends in certain places where we call apt to remove some of that image dize.

As for not having any QT spill over, we can remove kvantum along with calamares when the system installs.

oklopfer commented 11 months ago

We can’t use that flag because it’s just a package list for live-build, it’s not a custom install step. So no, we can’t easily get rid of the bloat without getting rid of Calamares altogether.

Also, we already do remove the dependencies post-install. But that means they still bloat up the ISO, which could be shrunk down quite a bit.

ajstrongdev commented 11 months ago

We can’t use that flag because it’s just a package list for live-build, it’s not a custom install step. So no, we can’t easily get rid of the bloat without getting rid of Calamares altogether.

This is a very good point, as someone who is on the fence at the moment both ideas have merit to me.