rhinobase / hono-openapi

A plugin for Hono to generate OpenAPI Swagger documentation
MIT License
191 stars 2 forks source link

Consider exporting types in package.json #7

Open luisbytes opened 1 week ago

luisbytes commented 1 week ago

It'd be great to have the types (types) explicitly exported in the package.json. This would make it easier for developers using the package to access type definitions, boosting code completion and helping avoid type errors.

marcomuser commented 1 week ago

Afaik the types are already explicitly exported in the package.json.

luisbytes commented 1 week ago

Afaik the types are already explicitly exported in the package.json.

I don't think so, I check the branches and I don't see the exported types.

marcomuser commented 1 week ago

What do you mean by branches? The types are exported in the package.json itself: https://github.com/rhinobase/hono-openapi/blob/6fb7626ed3387e82096aa85ae8f2507bb3654f72/packages/core/package.json#L32

Or do you mean to be able to import all type definitions individually as type imports?

luisbytes commented 1 week ago

What do you mean by branches? The types are exported in the package.json itself:

https://github.com/rhinobase/hono-openapi/blob/6fb7626ed3387e82096aa85ae8f2507bb3654f72/packages/core/package.json#L32

Or do you mean to be able to import all type definitions individually as type imports?

Yes, all of types.ts for example "DescribeRouteOptions"

MathurAditya724 commented 1 week ago

Sure, will do this in the next release.

MathurAditya724 commented 1 week ago

Thanks @marcomuser for taking the lead on this