search

rhinoman / go-commonmark

CommonMark wrapper for Go
Other
33 stars 6 forks source link

Make library go-gettable #1

Closed timshannon closed 9 years ago

timshannon commented 9 years ago

It would be fantastic if this could be bundled statically and built with go like out https://github.com/mattn/go-sqlite3 does it.

Since it's a pure-C library it should be possible.

timshannon commented 9 years ago

FYI, I forked your library and messed with it a bit, and was able to get it to work:

https://github.com/timshannon/go-commonmark/

Merge if you want, otherwise my fork suites my purposes for now.

Thanks,

rhinoman commented 9 years ago

Thanks, I like the idea. I'll take a look at this later tonight.

rhinoman commented 9 years ago

@timshannon, I checked out your fork and haven't been able to get it to run correctly (I removed my installed libcmark to make sure it wasn't linking that in, which it will do). Running 'go test' throws an error about the missing cmark library. What's your build procedure?

timshannon commented 9 years ago

Just go get works for me. Not sure what the issue is. I'll try it later on a fresh install. On Feb 11, 2015 8:17 AM, "James Adam" notifications@github.com wrote:

I checked out your fork and haven't been able to get it to run correctly (I removed my installed libcmark to make sure it wasn't linking that in, which it will do). Running 'go test' throws an error about the missing cmark library. What's your build procedure?

— Reply to this email directly or view it on GitHub https://github.com/rhinoman/go-commonmark/issues/1#issuecomment-73887291 .

timshannon commented 9 years ago

Just confirmed on a a fresh install of Ubuntu. Installed go, then did go get github.com/timshannon/go-commonmark and it installed fine.

Are you trying against your own repository? There were several things I needed to change in order to get it build properly with the go compiler.

rhinoman commented 9 years ago

Figured it out. commonmark_test.go in your fork was still importing go-commonmark from my repo... Seems to work fine, I think this will be easier/simpler than linking dynamically.

rhinoman commented 9 years ago

@timshannon, I'll merge this in -- go ahead and submit a pull request.

timshannon commented 9 years ago

Looks like you merged my change already and reverted it. I'll create a brand new repository / pull request so it can be merged properly.

rhinoman commented 9 years ago

Merged it in. Thanks.