Requires libxkbcommon, minor spec modernisation

rhinstaller / initial-setup

The Initial Setup utility takes care of post-installation configuration of an installed system.

GNU General Public License v2.0

27 stars 32 forks source link

Requires libxkbcommon, minor spec modernisation #150

Closed M4rtinK closed 8 months ago

M4rtinK commented 8 months ago

Backport of spec file changes from pbrobinson in distgit spec file - thanks! :)

NOTE: Moved the libxkbcommon dependency to the Xorg specific sub-package compared to the original distgit commit, as the sub-package was not yet there at that time.

Distgit commit link:

https://src.fedoraproject.org/rpms/initial-setup/c/da2a0bf2d131e98de9ef4417f737845ec3d82942?branch=rawhide

aleasto commented 8 months ago

I'm not sure libxkbcommon belongs in the xorg subpackage. I don't know how it is used, but:

wayland also uses XKB
even under wayland backends anaconda gui currently uses X11 through xwayland

M4rtinK commented 8 months ago

@aleasto Good point - I was unsure if its something really specific for Xorg or perhaps needed by both Wayland & Xorg as we still run on Xwayland. So moving it back to the original place from the ditgit commit, in the main package.

Ping @nullr0ute to possibly take a look. :)

Conan-Kudo commented 8 months ago

I incorporated this already into #151, so this can be closed for that.

M4rtinK commented 8 months ago

I incorporated this already into #151, so this can be closed for that.

ACK & thanks! :) Lets close this PR then.