search

rhkdump / kdump-utils

Kernel crash dump collection utilities
GNU General Public License v2.0
3 stars 8 forks source link

dracut-module-setup: Remove remove_cpu_online_rule() since PowerPC us… #16

Closed pfliu closed 2 weeks ago

pfliu commented 4 weeks ago 
dracut-module-setup: Remove remove_cpu_online_rule() since PowerPC uses nr_cpus

Now, PowerPC uses nr_cpus cmdline option, there is no worry about
bringing up all possible cpu since normally we finally only have 8 or 16
cpus if nr_cpus=1 on PowerPC platform. So 40-redhat.rules will not raise
trouble.

Signed-off-by: Pingfan Liu <piliu@redhat.com>
pfliu commented 4 weeks ago

This is a clean up after using nr_cpus=1 on PowerPC platform @sourabhjains, could you share your opinion

sourabhjains commented 3 weeks ago

@pfliu Since nr_cpus=1 is the default for PowerPC, I think we don't need to change 40-redhat.rules for kdump initrd.

Thanks for the clean-up patch; the changes look good to me.

Note for users who manually fall back to maxcpus=1: make sure to adjust the crashkernel reservation to accommodate the additional memory required for more CPUs in the kdump environment.