search

rhkdump / kdump-utils

Kernel crash dump collection utilities
GNU General Public License v2.0
3 stars 8 forks source link

kdumpctl: Only update fadump for ppc64le #19

Closed licliu closed 3 weeks ago

licliu commented 3 weeks ago

Fadump is only available for ppc64le, but reset_crashkernel() updates fadump unconditionally, which will cause non-ppc64le architectures to always reboot when run kdumpctl reset-crashkernel --reboot.

Barathrum-Liu commented 3 weeks ago

I think this issue may be fixed by kdumpctl: Simplify fadump handling in reset_crashkernel in PR#18, if we decide to merge that PR, we can close this one.

prudo1 commented 3 weeks ago

I think this issue may be fixed by kdumpctl: Simplify fadump handling in reset_crashkernel in PR#18, if we decide to merge that PR, we can close this one.

@Barathrum-Liu: indeed that commit also fixes the problem this PR is supposed to solve. I've updated the commit message accordingly. In case there are no rejections I propose to use the commit from my PR as that also leads to cleaner code (at least in my opinion).

@licliu: I also added a commit to update the man page with slightly different wording compared to yours. I hope that is ok with you.

IMHO this PR can be closed.