search

rhkdump / kdump-utils

Kernel crash dump collection utilities
GNU General Public License v2.0
3 stars 8 forks source link

fadump/udev: do not re-register fadump if kernel hotplug ready #7

Closed sourabhjains closed 1 month ago

sourabhjains commented 2 months ago

With the introduction of kernel commit c6c5b14dac0d ("powerpc: make fadump resilient with memory add/remove events") linux kernel now internally manages the update of elfcorehdr during memory add/remove events. So no need to re-register fadump if the /sys/kernel/fadump/hotplug_ready is set to 1.

No impact for kernels that do not have /sys/kernel/fadump/hotplug_ready sysfs.

Relevant kernel commit links:

  1. https://msgid.link/20240422195932.1583833-2-sourabhjain@linux.ibm.com
  2. https://msgid.link/20240422195932.1583833-3-sourabhjain@linux.ibm.com
sourabhjains commented 1 month ago

Any review/comments on this PR?

pfliu commented 1 month ago

This commit logic looks good to me.

sourabhjains commented 1 month ago

@pfliu @coiby Thanks for accepting the patch.