search

rhlsthrm / hardhat-typechain

TypeChain tasks for Buidler
MIT License
18 stars 13 forks source link

Accept underscores in contract names #16

Closed smartcontracts closed 3 years ago

smartcontracts commented 3 years ago

We're using underscores in our contract names over at https://github.com/ethereum-optimism/contracts/. Pattern matching here will only accept alphanumeric contract names, but underscores are valid.

gakonst commented 3 years ago

@rhlsthrm any chance you can take a look at this PR? Should be pretty easy to merge and publish a new version with this update!

rhlsthrm commented 3 years ago

Sorry @gakonst and @kfichter! Thanks for the PR.

rhlsthrm commented 3 years ago

Hi @kfichter @gakonst just FYI this package is now absorbed into the Typechain codebase! See https://github.com/ethereum-ts/TypeChain/tree/master/packages/hardhat for details. I will no longer be maintaining this.