rhlsthrm / hardhat-typechain

TypeChain tasks for Buidler
MIT License
18 stars 13 forks source link

Multiple improvements #8

Closed alcuadrado closed 3 years ago

alcuadrado commented 3 years ago

Hey @rhlsthrm,

I made some improvements to the plugin, without introducing breaking changes.

They are:

I also think that this plugin could override the compile task, so that calling typechain isn't required. This way you can keep your normal workflow and get the benefits of the plugin automatically. I think a --no-typechain param should be added, so that typechain errors don't prevent compilation. I didn't implement this because I wanted to get your opinion first.

Best Pato

rhlsthrm commented 3 years ago

I also think that this plugin could override the compile task, so that calling typechain isn't required. This way you can keep your normal workflow and get the benefits of the plugin automatically. I think a --no-typechain param should be added, so that typechain errors don't prevent compilation. I didn't implement this because I wanted to get your opinion first.

I like this idea @alcuadrado! I will implement this as a follow-up feature.