search

rhlsthrm / typescript-solidity-dev-starter-kit

Starter kit for smart contract development using Typescript
410 stars 127 forks source link

Needs a CI #14

Closed krzkaczor closed 4 years ago

krzkaczor commented 4 years ago

I think this project desperately needs a CI.

I just tried running it and run into multiple problems:

  1. npm install failed. Maybe it's just me?
  2. yarn succeeded (without a lockfile)
  3. Hardhat couldn't start due to coverage solidity-coverage problems
  4. contracts couldn't compile due to import from budiler (not from hardhat) in Counter.sol.
  5. Some problems around types in tests (needed additional any).

Can I somehow assist you with fixing those? I am the author of TypeChain and I loved your work on TC and HH integration :)

rhlsthrm commented 4 years ago

Thanks for reporting @krzkaczor, I love TypeChain so I'm happy to help however I can!

npm install failed. Maybe it's just me?

I just tried and it worked for me. I wiped my node_modules and package-lock.json and it worked. What version of node are you using? I'm using v12.18.1

Hardhat couldn't start due to coverage solidity-coverage problems

Correct, coverage plugin still hasn't updated to Hardhat.

contracts couldn't compile due to import from budiler (not from hardhat) in Counter.sol. Some problems around types in tests (needed additional any).

These are absolutely correct, and I've just fixed these issues.

I'll try to implement a rudimentary CI at least to make sure builds are working. Would love to get your input and of course PRs are always welcome!