search

rhlsthrm / typescript-solidity-dev-starter-kit

Starter kit for smart contract development using Typescript
410 stars 127 forks source link

Improve test for contract method expecting revert #18

Closed nharlow89 closed 3 years ago

nharlow89 commented 3 years ago

Thanks for the great starter kit. First issue I ran into was the failed test (I believe this was expected). Instead of failing, it would be more valuable to demonstrate how to test for expected reverts properly.

rhlsthrm commented 3 years ago

Thanks, this confuses people. The idea is however to show the Solidity stack traces. But I think you're right we should make this project pass tests.