Closed ghost closed 8 years ago
@harshitbudhraja: there are lot of issues that you have cleared here. Good job on that. But it would be better if you could open different merge requests for each of the branches so that it would be easier to understand all the changes you have made in them and comment on that. I'll still try to comment on these changes commit by commit but I'll be closing this PR and would need you to make different PRs for each issue as there are some things that will need to be improved in some cases.
Again, i'm not closing this because this is rejected, I just want you to send different PRs for different Issues.
For this you can use branches and for reusing the commits, you can use patches and re basing. Also, try to keep the commits squashed to being 1 commit per logical change. It makes it easier to review and test.
Anyways, good work :cake:
4
5
6
7
9 I'm still working on this
10