search

rhnvrm / breeze-website

:sparkles: Official Website for Breeze 2016 :sparkles:
http://rhnvrm.github.io/breeze-website
Apache License 2.0
4 stars 6 forks source link

Some issues resolved. #16

Closed ghost closed 8 years ago

ghost commented 8 years ago

4

5

6

7

9 I'm still working on this

10

rhnvrm commented 8 years ago

@harshitbudhraja: there are lot of issues that you have cleared here. Good job on that. But it would be better if you could open different merge requests for each of the branches so that it would be easier to understand all the changes you have made in them and comment on that. I'll still try to comment on these changes commit by commit but I'll be closing this PR and would need you to make different PRs for each issue as there are some things that will need to be improved in some cases.

4 - This commit is fine.

5 - Use the teal one, but try with a shadow if it looks good.

6 - Drop your commits for this. Cropping does not look good and I dont like the usage of dropping the resolution. Photoshop has a feature to compress the image for web. Let this be done by someone proficient in photoshop.

7 The buttons need some work with their design. Also, we need to update the meta tags.

9 @Sarthak-Mittal has implemented this and is improving it.

10 It looks fine but you need to make it responsive. Also the color of the address needs to match the theme.

harshitbudhraja github io-breeze-website-

Again, i'm not closing this because this is rejected, I just want you to send different PRs for different Issues.

For this you can use branches and for reusing the commits, you can use patches and re basing. Also, try to keep the commits squashed to being 1 commit per logical change. It makes it easier to review and test.

Anyways, good work :cake: