rhnvrm / breeze-website

:sparkles: Official Website for Breeze 2016 :sparkles:
http://rhnvrm.github.io/breeze-website
Apache License 2.0
4 stars 6 forks source link

Improve Theme Video section and Fix #22

Closed rhnvrm closed 8 years ago

rhnvrm commented 8 years ago
FlameFractal commented 8 years ago

Check on https://flamefractal.github.io/breeze-website/ and tell me if something needs to be changed regarding the theme section, before i send a PR. Video autoplay works as required. Check on phone by clicking Theme from hamburger menu. I've kept the mobile media query @768px. Tell me if you want it to be decrease/increased.

Also, I have raised an issue regarding the padding problem. Till it is solved, I have used inline padding in theme

. Hope we remove that at a later time.

ghost commented 8 years ago

@FlameFractal Nice work with the video autoplay :)

FlameFractal commented 8 years ago

@harshitbudhraja yo, thanks. media queries ftw!

mr-karan commented 8 years ago

http://tympanus.net/Tutorials/VideoOpeningAnimation/

^ See this and decide do we want something of this sorts ? :D Btw I like the present more, just sharing an alternative.

rhnvrm commented 8 years ago

LGTM :+1:

rhnvrm commented 8 years ago

@FlameFractal The video starts playing even if I click on Previous performers. Look into scrollspy provided by the theme we have used Scrollspy that highlights active page sections (http://startbootstrap.com/template-overviews/grayscale/) Also, we should lose the exclamation mark in the menu and have a h1 tag inside it's section. It's also missing a scroll arrow and the scroll arrow above it points to contact section.

You can also reduce the padding from 250px to 100px in grayscale:233 resolving #28

Also, fix the height of the carousel.

Also since you have not sent a PR yet, pull the changes from upstream and resolve the merge conflicts and check if any new changes cause any new bugs.

rhnvrm commented 8 years ago

#