search

rhobs / observability-operator

Create Monitoring Stacks you need on your Kubernetes clusters!
32 stars 56 forks source link

Discuss tools setup for CI #241

Open jan--f opened 1 year ago

jan--f commented 1 year ago

Currently the tools we need for CI have no defined install policy. For some tools we install specific versions and make sure that version is used. For other tools we install latest or similar and sometimes check that the version we want is actually executed. I.e. for some tools the version is never actually checked. Currently the main purpose of the versions defined in Makefile.tools is to cache tools for github actions and update the cache if necessary. This topic came up in #239.

We should agree on a policy to either pin specific version or use latest.

simonpasquier commented 1 year ago

My 2 cents: I'm usually in favor of using pinned versions as it guarantees better reproducibility and avoids unattended breakages.

JoaoBraveCoding commented 1 year ago

I agree with Simon on this one 👍

sthaha commented 1 year ago

Agree with Simon. Pinning allows reproducibility and consistency across all envs (dev, ci, ..). The additional benefit is that we cache the tools and thereby close to zero transient errors because of network issues.

We do need a periodic task to upgrade the tools.