Closed marioferh closed 4 months ago
/hold shellcheck is blocking
/hold shellcheck is blocking
is no shellheck, is this test after the enableGate type change:
+++ expected
map[string]any{
... // 2 identical entries
"f:alerting": map[string]any{"f:alertmanagers": map[string]any{}},
"f:arbitraryFSAccessThroughSMs": map[string]any{},
- "f:enableFeatures": map[string]any{`v:"otlp-write-receiver"`: map[string]any{}},
+ "f:enableFeatures": map[string]any{},
"f:enableRemoteWriteReceiver": map[string]any{},
"f:externalLabels": map[string]any{"f:key": map[string]any{}},
... // 24 identical entries
}
let me fix it
> "f:enableFeatures": map[string]any{
v:"otlp-write-receiver": map[string]any{}},
in fact before the expected was:
"f:enableFeatures": map[string]any{},
and the test passed... should be:
"f:enableFeatures": map[string]any{
v:"otlp-write-receiver": map[string]any{}},
as right now..
if:
EnableOtlpHttpReceiver: func(b bool) *bool { return &b }(true),
then:
there was a bug before?
there was a bug before?
no bug but an upstream change that broke the test :)
https://github.com/prometheus-operator/prometheus-operator/commit/3e0d0f86f2
/lgtm
/unhold
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: marioferh, simonpasquier
The full list of commands accepted by this bot can be found here.
The pull request process is described here