rhobs / observability-operator

Create Monitoring Stacks you need on your Kubernetes clusters!
32 stars 56 forks source link

feat: bump Prometheus operator to v0.74.0 #518

Closed marioferh closed 4 months ago

openshift-ci[bot] commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: marioferh, simonpasquier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/rhobs/observability-operator/blob/main/OWNERS)~~ [marioferh,simonpasquier] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
simonpasquier commented 4 months ago

/hold shellcheck is blocking

marioferh commented 4 months ago

/hold shellcheck is blocking

is no shellheck, is this test after the enableGate type change:

    +++ expected
      map[string]any{
        ... // 2 identical entries
        "f:alerting":                    map[string]any{"f:alertmanagers": map[string]any{}},
        "f:arbitraryFSAccessThroughSMs": map[string]any{},
    -   "f:enableFeatures":              map[string]any{`v:"otlp-write-receiver"`: map[string]any{}},
    +   "f:enableFeatures":              map[string]any{},
        "f:enableRemoteWriteReceiver":   map[string]any{},
        "f:externalLabels":              map[string]any{"f:key": map[string]any{}},
        ... // 24 identical entries
      }

let me fix it

marioferh commented 4 months ago

> "f:enableFeatures": map[string]any{v:"otlp-write-receiver": map[string]any{}},

in fact before the expected was: "f:enableFeatures": map[string]any{}, and the test passed... should be:

"f:enableFeatures": map[string]any{v:"otlp-write-receiver": map[string]any{}},

as right now..

if: EnableOtlpHttpReceiver: func(b bool) *bool { return &b }(true),

then:

https://github.com/rhobs/observability-operator/blob/95cc34843899fa4378e21509271960d49b31f06a/pkg/controllers/monitoring/monitoring-stack/components.go#L188

there was a bug before?

simonpasquier commented 4 months ago

there was a bug before?

no bug but an upstream change that broke the test :)

https://github.com/prometheus-operator/prometheus-operator/commit/3e0d0f86f2

/lgtm

marioferh commented 4 months ago

/unhold