rhockenbury / homebridge-ecowitt-weather-sensors

Complete HomeKit support for Ecowitt Weather Sensors with Homebridge
https://www.npmjs.com/package/homebridge-ecowitt-weather-sensors
Apache License 2.0
1 stars 0 forks source link

More fine grained way of hiding properties in devices #42

Open hashat opened 1 week ago

hashat commented 1 week ago

Currently there seems to be a way of hiding either

Would there be a way to make this more fine-grained in case I want to hide humidity only in WH65? Use case: I have multiple devices measuring the same property, and I'd like to show only one of these in the Home app.

hashat commented 1 week ago

UPDATE: I just see this is a documentation / UI issue, because it is definitely possible to do it directly in the JSON config file:

"hidden": {
    "WH65:temperature": true,
    "WH65:humidity": true
},

However, it's also true that since currently there seems to be no way of setting this on the form-based config sheet, if someone alters anything there and the config gets re-generated based on the form, then this fine-grained setting will be lost.

rhockenbury commented 1 week ago

Hi @hashat. Thanks for reaching out. This is something that I struggled with, and went with an 80 / 20 solution. From the plugin config UI, you are correct that "hiding" is either a weather property across all devices, or a full specific accessory. As you pointed out, I left in the implementation for hiding a specific property on a specific device, but that can only be configured through the plugin json directly. This has the caveat that the user would have to only configure the plugin through the json config going forward or risk resetting values, and I chose not to document this capability for that reason.

I think this approach would be okay for most users, providing a UI-based way to hide things for most common use cases, but retaining more advanced functionality if needed (with the slight annoyance of working directly with the json config). Let me know your thoughts.

hashat commented 1 week ago

Agreed with your reasoning about the 80/20 solution now. Nevertheless let me point out some further considerations:

Just typed these in because you asked for my thoughts :)

rhockenbury commented 1 week ago

Thanks for the feedback! Always appreciate it.

I'm aware that there's been confusion in getting the names of the properties for renaming so I definitely agree that more documentation around that would be a benefit.

I had briefly looked at doing a custom UI for the plugin which would would permit more flexibility. I can take a look at the example you mentioned to understand the LoE and see if the investment might be worth it.