search

rhodan412 / ActionBarProfiles

Create and update profile loadouts for your talents, action bars, macros and more
MIT License
0 stars 0 forks source link

Macros not loading correctly #2

Open nuubcake11 opened 2 months ago

nuubcake11 commented 2 months ago

Which version are you using when bug occurred Last Version

Describe the bug When profile is loaded, action bars that had a macros, ALL are replaced with a the FIRST macro from my macro list, not the desired one.

To Reproduce Steps to reproduce the behavior:

  1. Go to Addon panel
  2. Click on Use
  3. Macros loading incorrectly

Expected behavior Macros loading from the saved ones, not the first addon is the list.

Screenshots image Wow_teCIdTG5j4

rhodan412 commented 2 months ago

Alright so I started off on a fresh character that I hadn't touched in a long time, saved the bars/macros/etc and deleted all of my global and character macros.

wow01 wow02

Then I hit "Use" and my macros came back just as I had saved them and on the correct location on the action bar (am using bars 1, 2, 3 and 4)

wow03

The one thing I am noticing is that the macro that was listed on ActionButton 1 is the only one that reappears inside the character macro tab whereas the other macros that existed on the action bars for that profile were re-created in the global macro tab (any other macros that existed that were part of other profiles, possibly due to different macros used across other specs don't appear or aren't re-created, this part is the way that the add-on had been originally designed by the previous author).

wow04

In terms of profiles I am using the profile "Warrior"

wow05

This behavior remains the same even with the ActionBarProfiles add-on as the only one loaded

wow06

Notice how the global and character macros have "#showtooltip DON'T KNOW" and "#showtooltip NO CLUE" in the macro body, which is the way that I saved them for this test

Unless you're using another add-on that could be using different names of the actionbars/buttons over the default Blizz ones, I don't know why you are seeing your macros restored to the bars incorrectly (as this could be due to buttons from an action bar add-on being outside of the scope of what's being handled by ABP).

I will look into the reason why all but one of the macros are being restored to the global and only the one being restored into the character tab as this at least shouldn't be the way the addon is handling macros.

rhodan412 commented 2 months ago

I have an idea for what is needed with the macros and hopefully I can get it where it stores the global and character macros in a separate section and references them from within the profile part of the DB. It will be the best way to fix it (possibly one of the few or only), but it will take a bit of time to do a rewrite on how the save/restore is done. This should allow character-side macros to be kept saved to that tab and the globals saved there, with some future-proofing.