Summary

[tbergen1]

Rubric Score

Criteria 1: Table Creation

• Score Level: 4/4 (Exceeds Expectations)
• Comment(s): It looks like you have included all of the proper code in your migration.js file for creating the proper tables with appropriate relationships to each other. It is also formatted well, making it easy to read. Nice work!

Criteria 2: Implementation of API Specification and Functionality

• Score Level: 4/4 (Exceeds Expectations)
• Comment(s): It looks like all route paths and functionality are implemented to the spec. You handled all errors in each route well and also made the port configurable. Nice job!

Criteria 3: Test Case Results

• Score Level: 3/4 (Meets Expectations)
• Comment(s): Running the testing suite against your code yielded mostly passing results. Your code failed against 3 tests, so I would recommend going back through and checking the code again to fix this. Nice work with this!

Criteria 4: JavaScript and Express Fundamentals and Formatting

• Score Level: 4/4 (Exceeds Expectations)
• Comment(s): You did well using JS features as well as Express features, such as middleware, route parameters, etc in your code. You also did well with the formatting of your code, which made it easy to read and understand. Nice job!

Overall Score: 15/16

Overall, you did a great job with this project. You implemented the API to spec and formatted it well, making it easy to read. You showed good knowledge of JS and Express by leveraging their features in your code. Almost all of your tests passed as well, showing that you wrote your code mostly to spec. Great work!

[rhoffen]

Hi Tom, Thanks for the review! About the tests, I wanted to let you know that the tests written for this project were not entirely isolated from each other. I would get a route passing, write another route, run the tests again, and have the previous route fail. Then I ran the tests again without changing anything and they would pass. I reported this to the mods in the intensive channel, and they agreed that there have been problems with these tests all along.

FWIW, all the tests were passing on my end before I submitted. I suggest that you run the test suite more than once. I think it may have something to do with the database not being completely disconnected between every test run.

Thanks again!