search

rhomobile / rhoconnect-java

0 stars 2 forks source link

JSONObject to ObjectMapper #3

Closed vineey closed 11 years ago

vineey commented 11 years ago

Changed the implementation of json conversion of rhoconnect java plugin, from JSONObject API to ObjectMapper API.

vineey commented 11 years ago

I actually disabled the test suite by deleting the test cases, cause its not allowing me to generate the binary and source jar files. If this is approved, you could add the compatible test suite.

vineey commented 11 years ago

I'm planning to add additional modifications on this forked version, regarding automatic dispatching of request to the respective Services. It uses lowercase of model name plus "ServiceImpl". There are other practices that could be broken due to this requirement such as in our side, we use the convention model name(which is camel case) plus "Service". But to be not dependent on this method of locating services, we could use class type searching of service and if there are more than one service that matches this class type, then the second criteria is to use the id naming convention which should be allowed to be overridden in the existing application. But most of the time, there is only one service that matches the class type.

larsburgess commented 11 years ago

Sorry about taking so long to get back to this, @shurab please review when you get a chance.

shurab commented 11 years ago

I would rather prefer have a branched version of rhoconnect-java with full similar suite of tests that master has.

At this moment project include rhoconnect-java pligin, java-api (it's based on on plugin) that provides REST API for java clients, and test suite based on WireMock library. We should have a full set of tests to cover all changes.