search

rhoneyager / libicedb

A toolbox for snow particle modeling!
https://rhoneyager.github.io/libicedb
Other
0 stars 1 forks source link

Fixing #12. #23

Closed rhoneyager closed 6 years ago

rhoneyager commented 6 years ago

Fixes #12.

Shape coordinates can either be stored as floats or as int32_t.

TODO: Make sure that Eugene's code works with this convention. TODO: Add typedefs and document the variable types more thoroughly.

DaveOri commented 6 years ago

Thanks Ryan for the new functionality. I had to go through the code once due to a couple of issues: 1) Changing particle_scattering_element_number from uint64 to int64 was causing building issues and segfault (you might want to see my modifications to shapes.hpp and Shapes.cpp) 2) The shapefile parsing function were still not accepting negative numbers. I have implemented a mod

The current version is working for me. I didn't tested on PSU files. You might want to review before merging

rhoneyager commented 6 years ago

PSU files use a different mechanism. They are fortunate to not have to directly parse raw text.

The changes work for me, too, and are needed for fixes to handle Robin's flakes, so I'm going to merge it here.