rhoneyager / libicedb

A toolbox for snow particle modeling!
https://rhoneyager.github.io/libicedb
Other
0 stars 1 forks source link

Update spread-sheets of 3D structure #30

Open stefankneifel opened 6 years ago

stefankneifel commented 6 years ago

Include changes/modifications discussed at the last scattering meeting (17/May/2018). Please all: revise the spreadsheet and comment!

stefankneifel commented 6 years ago

Spread-sheet is updated according to our discussion yesterday (3D structure and meta-data). @rhoneyager @DaveOri @eec3 please revise, thanks!

stefankneifel commented 6 years ago

@rhoneyager : I just saw, that the spread-sheet one can find on the homepage is not automatically sync-ed with google...

rhoneyager commented 6 years ago

@stefankneifel On Google drive, I can see three copies of structure_scattering_datasets.xlsx.xlsx, last modified Nov. 13, Aug. 16 and Aug. 2. Did you make another copy somewhere?

rhoneyager commented 6 years ago

Okay, I switched the site to use your version.

rhoneyager commented 6 years ago

@stefankneifel

Two things:

  1. For particle_scattering_element_coordinates, did the meeting discuss changing the dimensions from "particle_scattering_element_number, 3, constituent_id" to "particle_scattering_element_number, 3"?

  2. particle_constituent_number/constituent_id/particle_constituent_id should also be a local dimension, with a consistent name.

eec3 commented 6 years ago

Hello Ryan,

  1. For particle_scattering_element_coordinates, did the meeting discuss changing the dimensions from "particle_scattering_element_number, 3, constituent_id" to "particle_scattering_element_number, 3"?

I cannot remember if we discussed this during the last Skype, but will

"particle_scattering_element_number, 3"

work? How would we handle particles with multiple constituents such as liquid and ice water? Seems to me that

"particle_scattering_element_number, 3, constituent_id"

would work best in this regard.

  1. particle_constituent_number/constituent_id/particle_constituent_id should also be a local dimension, with a consistent name.

I like

"particle_constituent_number"

as a single number for the number of constituents. For our database it will always be one. And I like

particle_constituent_id(particle_constituent_number)

as the dimension to hold the individual constituent IDs.

My two cents.

Eugene

rhoneyager commented 6 years ago

For 1: We already have a separate variable for that: particle_scattering_element_composition. The coordinates variable basically reads as "the nth scattering element is centered at (X,Y,Z)", while the composition variable says "the nth scattering element is (70% ice, 30% water)".

At least, that is how I am interpreting the variables based on the description and comments columns.

eec3 commented 6 years ago

Ryan, This all works for me and brings back memories of prior discussions from a long, long time ago. :*) Eugene

----- Original Message -----

From: "Ryan Honeyager" notifications@github.com To: "rhoneyager" libicedb@noreply.github.com Cc: "Eugene Clothiaux" eec3@psu.edu, "Assign" assign@noreply.github.com Sent: Wednesday, May 30, 2018 1:25:27 PM Subject: Re: [rhoneyager/libicedb] Update spread-sheets of 3D structure (#30)

For 1: We already have a separate variable for that: particle_scattering_element_composition. The coordinates variable basically reads as "the nth scattering element is centered at (X,Y,Z)", while the composition variable says "the nth scattering element is (70% ice, 30% water)".

At least, that is how I am interpreting the variables based on the description and comments columns.

-- You are receiving this because you were assigned. Reply to this email directly or view it on GitHub: https://github.com/rhoneyager/libicedb/issues/30#issuecomment-393247944