search

rhostem / ng2-simple-autocomplete

ng2-simple-autocomplete
MIT License
6 stars 2 forks source link

- Allow 3rd-party/custom classes for input #4

Closed ChaudhryAtif closed 7 years ago

rhostem commented 7 years ago

Thank you for PR. But I merged after modifying your commit. For example, frameworkInputStyle has too narrow meaning and looks like inline style instead of classname. So I changed it to just 'classNames'. And removed useCSSFramework property.

I made elements in component inherits the root element(div.autocomplete)'s styles for consistency. So just one classnames property is needed. Styling specific element like this has surely more clearness and flexibility, but I want to do like this for now.

ChaudhryAtif commented 7 years ago

Sounds good. Thanks for the merge!