rhsimplex / image-match

🎇 Quickly search over billions of images
2.94k stars 405 forks source link

Wrong P x P square centered coordinate computation #124

Closed nvtu closed 4 years ago

nvtu commented 4 years ago

As mentioned in the paper, the P x P square at the grid point need to be centered. However, the implementation in compute_mean_level in goldbert.py file of the P square starting coordinates seem wrong. lower_x_lim = int(max([x - P/2, 0])) lower_y_lim = int(max([y - P/2, 0])) The correct one should be: lower_x_lim = int(max([(x - P)/2, 0])) lower_y_lim = int(max([(y - P)/2, 0]))