search

rhsimplex / image-match

🎇 Quickly search over billions of images
2.94k stars 405 forks source link

skimage `imread` as_grey vs as_gray #130

Open gwd666 opened 4 years ago

gwd666 commented 4 years ago

Just to let you know, make you aware that based on https://stackoverflow.com/questions/58993530/typeerror-self-open-got-an-unexpected-keyword-argument-as-grey-python I ran into that same issue ... it may require, at least this fixed it for me, a small tweak in goldberg.py to line 239 and 246 from return imread(image_or_path, as_grey=True) to return imread(image_or_path, as_gray=True)

Otherwise nice piece of work!

JavisPeng commented 4 years ago

you need reinstall the scikit-image 

 pip install scikit-image==0.14.0
gwd666 commented 4 years ago

you need reinstall the scikit-image

 pip install scikit-image==0.14.0

Since [I think] they changed the parameter naming in scikit-image 0.15 I get your advice.; I am on scikit-image 0.17.1 - with the small above tweak to the imread calls it is no big deal; would there be any other reason for downgrading by ~6 versions, issues with 0.17 and your code I am not aware of? Otherwise it could just benefit others if we leave this ticket open, in case someone else runs into the same issue?

darkfader commented 3 years ago

so we all just stick to old versions now?

jose1711 commented 3 years ago

I haven't see any issues with a manually patched version either.