search

rhsimplex / image-match

🎇 Quickly search over billions of images
2.94k stars 405 forks source link

adding py3 fix for unicode checking #15

Closed zeyaddeeb closed 8 years ago

rhsimplex commented 8 years ago

Hey @thelostscientist, thanks for helping us start down the road towards python3 compatibility (#3) with this and PR #14.

I'm having a little trouble getting this to work on python3, but I think I understand what you are trying to do: get preprocess_image to accept python3 bytes type. Could you post a motivating example of why you made this change, and a working example? Then maybe I can suggest some further modifications to preprocess_image.

Part of the issue, I believe, is that we depend on scikit-image and PIL, which is kind of a mess that I need to clean up.

lprimeroo commented 8 years ago

unicode is str and str is bytes in py3. Unless a different thought process / method exists , this PR makes no sense .