Addresses issue #18. Not ready to merge, having trouble getting the tests which rely on Elasticsearch to succeed (I don't think the Elasticsearch container spins up)... @vrde @sbellem
docker-compose run --rm image-match py.test -v
Also welcome remarks on the tests themselves. For instance the first test in test_elasticsearch_driver.py tests the connection to Elasticsearch. Would be nice if a failure here autofailed the rest. Also some of the tests depend on Internet connectivity or have magic numbers, etc. Not sure the convention.
Addresses issue #18. Not ready to merge, having trouble getting the tests which rely on Elasticsearch to succeed (I don't think the Elasticsearch container spins up)... @vrde @sbellem
docker-compose run --rm image-match py.test -vAlso welcome remarks on the tests themselves. For instance the first test in
test_elasticsearch_driver.pytests the connection to Elasticsearch. Would be nice if a failure here autofailed the rest. Also some of the tests depend on Internet connectivity or have magic numbers, etc. Not sure the convention.