Don't store signature in ElasticSearch index

[ecdeveloper]

• Sort/cutoff by elasticsearch relevance score instead (references #2)

[rhsimplex]

Hey thanks for submitting. Hopefully I can review this soon. The test is failing because of something on my end, so I have to fix that first.

[rhsimplex]

Hey @ecdeveloper sorry I took so long to get around to this. I fixed the build in master, can you rebase?

Thank you

[ecdeveloper]

Thanks, @rhsimplex. I fixed some of my tests, still have to fix a few of them, and probably need to add some tests around checking the score (as you do with dist).

[ecdeveloper]

Fixed all tests, except for a single one in test_elasticsearch_driver_metadata_as_nested. Will take a closer look tomorrow.

[rhsimplex]

That's the test for adding metadata, which should be ignored in the image search. Maybe the query is including it. I'll look too.

[rhsimplex]

Another update on my side -- since your change affects the behavior on a lot of the code, it's important we make sure the tests are actually hitting all your changes. I'll need to get codecov up and running (which means enlisting the help of @vrde since I no longer work at Ascribe) and possibly update the tests to do all checks with and without signatures.

Thanks for your patience, it's just a big change so I want to get it right :1st_place_medal:

[ecdeveloper]

Sure, no rush here. Thanks for your assistance.

[rhsimplex]

Sorry @ecdeveloper, I haven't forgotten this. Both myself and @vrde were coincidentally on vacation!

[ecdeveloper]

@rhsimplex No worries. I just got back from a vacation too ;)

[rhsimplex]

We finally got Codecov. Can you rebase on master so it runs the report?

[ecdeveloper]

@rhsimplex yay! k, rebased.

[rhsimplex]

Believe it or not, I haven't forgotten about this PR. Looking into why the metadata filter test is failing.

[ecdeveloper]

@rhsimplex Come on, man! I believe in you 😄 Actually, no worries. Take your time ;)