search

rhsimplex / image-match

🎇 Quickly search over billions of images
2.94k stars 405 forks source link

Elasticsearch 6 compatibilty #97

Open CMCDragonkai opened 6 years ago

CMCDragonkai commented 6 years ago

Does image-match work with elasticsearch 6? It doesn't seem like there was any relevant breaking changes. If so, can we bump up the version constraint in the setup.py?

duhaime commented 6 years ago

@fabito Do you recall why you specified the elasticsearch module version as 'elasticsearch>=5.0.0,<6.0.0', [commit]? All the tests pass on 6.2.0; in fact it's the only version with which I've run image-match!

RicardoBrazao commented 6 years ago

Any news regarding this issue @duhaime ? I'm also facing some problems because v1.1.2 is still with an older version of elasticsearch.

markusressel commented 5 years ago

I use it with elasticsearch 6.3.1 without any issues... I would really like to bumb the version too. Is there any reason not to do this?

fabito commented 5 years ago

@fabito Do you recall why you specified the elasticsearch module version as 'elasticsearch>=5.0.0,<6.0.0', [commit]? All the tests pass on 6.2.0; in fact it's the only version with which I've run image-match!

AFAIR no specific reason. If the tests are passing I don't see why we shouldn't upgrade.

markusressel commented 5 years ago

I did not run tests (haven't even cloned this repo so far), but I use it in my own little library without any issues. Currently I just set the elasticsearch version in my setup.py to enforce the newer version.