search

rht-labs / enablement-docs

Collection of Enablement material for Red Hat Open Innovation Labs
https://rht-labs.github.io/enablement-docs/#/
90 stars 114 forks source link

[BUG] Inconsistent Instructions between repositories #544

Open tmichett opened 4 years ago

tmichett commented 4 years ago

https://rht-labs.github.io/enablement-docs/#/2-attack-of-the-pipelines

http://localhost:8085/#/2-attack-of-the-pipelines/

https://github.com/rht-labs/enablement-docs

tmichett commented 4 years ago

Should be like this:

The Jenkinsfile is mostly complete, however some minor changes will be needed to orchestrate namespaces. Find and replace all instances of in the Jenkinsfile. Update the to the one you log in to the cluster with; this variable is used in the namespace of your Git projects when checking out code etc. Replace with your Git domain (only the hostname, without https:// or the repository name).

This is correct with the localhost documentation and Github

However, https://rht-labs.github.io/enablement-docs/#/2-attack-of-the-pipelines

has

The Jenkinsfile is mostly complete however some minor changes will be needed to orchestrate namespaces. Find and replace all instances of in the Jenkinsfile. Update the to the one you login to the cluster with; this variable is used in the namespace of your git projects when checking out code etc. Ensure the GITLAB_DOMAIN matches your git host.

tmichett commented 4 years ago

Needs comments about the only the FQDN hostname

tmichett commented 4 years ago

It would appear that on the

https://github.com/rht-labs/enablement-docs

The: Course Content: https://rht-labs.github.io/enablement-docs/#/

contains outdated information and guides.