search

rht-labs / enablement-docs

Collection of Enablement material for Red Hat Open Innovation Labs
https://rht-labs.github.io/enablement-docs/#/
90 stars 114 forks source link

Updated README to ensure changes are made to master branch #562

Closed tomchalmers closed 4 years ago

tomchalmers commented 4 years ago

Whilst part of the DO500 course and working through the Attack of the Pipelines task we noticed that the code changes made to the develop branch relating to the Jenkinsfile were not applied to the master branch.

Without this proposed change we found the given instructions missed the code change to the master branch and caused the master pipeline within Jenkins to display red. For those new to the technical process this confused them and the difference between develop and master branch wasn't made clear.

There is of course a few ways to make development and master identical however these small steps helped us explain within our team the reasoning of what we were doing.

To avoid this confusion, I have added some brief instructions to the README as well as providing the image once these steps are run, the output being 2 green pipelines for both develop and master branch.

tomchalmers commented 4 years ago

@springdo, for some reason I am unable to successfully link this PR to the open Issue (possibly due to permissions?) either way this PR should resolve https://github.com/rht-labs/enablement-docs/issues/524