search

rht-labs / enablement-docs

Collection of Enablement material for Red Hat Open Innovation Labs
https://rht-labs.github.io/enablement-docs/#/
90 stars 115 forks source link

Add "view entire file" tabs to tech exercises #606

Open jacobsee opened 3 years ago

jacobsee commented 3 years ago

These let you see what the entire file should look like once you've made the appropriate edits, to help out with misunderstandings about where things go, bracket problems, etc. Should reduce the amount of "simple mistakes".

Rendered example:

Screen Shot 2021-01-26 at 10 11 31 PM
jacobsee commented 3 years ago

Leaving as a draft pending a conversation tomorrow.

eformat commented 3 years ago

woot ... this is really good @jacobsee .. should merge this into master at some point

paulbarfuss commented 3 years ago

Hey @jacobsee @eformat @sdstolworthy just wanted to leave a quick review.

Looks like overwhelmingly positive comments for the quality of work and the need to get this into enablement-docs. Can we get this PR'd into master and gh-pages branches please? I am not sure if there is any other benefit to the current target branch but would love to have this for upcoming DO500s based on feedback from recent classes.

I am happy to help review and test the changes.

sdstolworthy commented 3 years ago

Agreed. Would love to see this get merged in.

jacobsee commented 3 years ago

@sdstolworthy This includes your changes from #607... Is everything there ready to go as well? I'm fine with getting this merged into a main branch sooner rather than later but also not sure that we should rush this (and everything that will be pulled along with it) for use next week.