🐅 no_helm key is removed 🐅

rht-labs / ubiquitous-journey

🧰 Open Innovation Labs Developer Experience - all the tooling for starting a residency

http://rht-labs.com/ubiquitous-journey

Apache License 2.0

102 stars 80 forks source link

🐅 no_helm key is removed 🐅 #230

Closed ckavili closed 2 years ago

ckavili commented 2 years ago

Removed releaseName key as the default value is already the application CR name and it is recommended to not change https://argo-cd.readthedocs.io/en/stable/user-guide/helm/#helm-release-name
Removed no_helm key as if we have values and/or helm_values keys, it is enough to have if block anyway. if not .no_helm sounds a bit confusing 😁

eformat commented 2 years ago

i had to reaad this twice, but i think it looks ok!

eformat commented 2 years ago

@ckavili - how about removing no_helm from the values-tooling.yaml file as well and deploying to test this ? looks like its still on the CRW and microcks apps

ckavili commented 2 years ago

haha sorry for my cryptic comments up there 😁 I already removed the key from values-tooling file. That must be the files under the archive folder you are seeing..I didn't touch that folder 🧐