rhtconsulting / cfme-rhconsulting-scripts

GNU General Public License v2.0
65 stars 48 forks source link

buttons rake not updating dialog_label #52

Open marc-torres opened 8 years ago

marc-torres commented 8 years ago

When I attempt to update an existing button with the button rake, I can clearly see the dialog_label is correctly set in the buttons.yml I'm about to rake and import into cloudforms, and the debug output properly shows the correct dialog.id , but when the import is finished, only the 'Hover text' is updated. The dialog_label is never updated with what I have in my buttons.yml.

branic commented 8 years ago

@marc-torres can you provide an example and steps to reproduce? Also, what version of CloudForms or ManageIQ is being used?

marc-torres commented 8 years ago

@branic details below!

Cloudforms 3.2 on RHEL6

Issue Description: Rake script is importing changes into Cloudforms. For 1 particular button (Delete VM button) , when I run the rake, it fails to update the 'dialog label' for this particular existing button.

The Delete VM button was a pre-existing button although I had to change the dialog that it referenced. THe old dialog pointed to 'Remedy Ticket'. My new changes (that I'm raking in ) has the dialog set to 'Delete VM'.

I can see when I run the rake, in debug mode that it's properly setting the right element in the array that's getting sent. The 'HOver text' is updating for the button, but the dialog label is not. Which leads me to believe its only that element in particular that fails to update.

Unfortunately I cannot post screen shots but they are available through a Red Hat case. Would you like for me to post the case # ?

branic commented 8 years ago

@marc-torres directly send me the case # and I'll take a look (bevans@redhat.com)

branic commented 8 years ago

@marc-torres thanks for the email. I've had a look at the case.

The dialog_label (Dialog field in the UI) is the name of the Service Dialog to display when the button is clicked.

Do you have a Service Dialog named 'Delete VM'? In the Web UI do you see the service dialog in the Dialog drop-down when editing the button?

I haven't been able to reproduce this on my 3.2 instance. If the Service Dialog exists the Dialog field is updated. If it doesn't exist I get a "Unable to locate dialog" error.

marc-torres commented 8 years ago

Yes , I have a 'delete vm' button. It used to be named 'remedy ticket'. So I changed it to reflect 'delete vm' then exported the configuration , then imported it into another environment which already had the 'remedy ticket' button. When I do so, the dialog_label does not get updated to reflect "delete vm' , it stays "remedy ticket". Hope that clears it up

    _____________________________

@marc-torres thanks for the email. I've had a look at the case.

The dialog_label (Dialog field in the UI) is the name of the Service Dialog to display when the button is clicked.

Do you have a Service Dialog named 'Delete VM'? In the Web UI do you see the service dialog in the Dialog drop-down when editing the button?

I haven't been able to reproduce this on my 3.2 instance. If the Service Dialog exists the Dialog field is updated. If it doesn't exist I get a "Unable to locate dialog" error.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

branic commented 8 years ago

The Dialog field (dialog_label in the YAML file) controls which Service Dialog to display (if any) when the button is clicked (on a VM in this case). Service Dialogs are different than buttons and are found on Service Dialogs accordian (just above the Buttons accordian).

Can you email me a screenshot of what the button looks like in the environment that the export comes from?

When performing the imports are the Service Dialogs being imported before the Buttons?

wce3 commented 7 years ago

Is this issue still open? We are hitting it with button imports with cfme 5.6.3.3. We're using the scripts from commit 81b8bad44 (Jul 21 2016) I can provide Details how it occurs on our Systems.