Unable to edit imported Service Catalog Items

[branic]

When a Service Catalog is imported with Catalog Items that have a type other than generic (such as VMware) the import results in the catalog item being editable.

[gaetanquentin]

cloudforms 4.2:

We cannot see the content either: a display bug let the previous catalog item.

==> production.log <== [----] I, [2018-03-16T09:44:18.846454 #2998:13c949c] INFO -- : Started POST "/catalog/tree_select/?id=stc-1r7_st-1r20" for 127.0.0.1 at 2018-03-16 09:44:18 +0100 [----] I, [2018-03-16T09:44:18.848354 #2998:13c949c] INFO -- : Processing by CatalogController#tree_select as JS [----] I, [2018-03-16T09:44:18.848442 #2998:13c949c] INFO -- : Parameters: {"id"=>"stc-1r7_st-1r20"} [----] F, [2018-03-16T09:44:18.902660 #2998:13c949c] FATAL -- : Error caught: [NoMethodError] undefined method resource_id' for nil:NilClass /var/www/miq/vmdb/app/controllers/catalog_controller.rb:1742:inget_node_info' /var/www/miq/vmdb/app/controllers/catalog_controller.rb:1824:in replace_right_cell' /var/www/miq/vmdb/app/controllers/catalog_controller.rb:281:intree_select' /opt/rh/cfme-gemset/gems/actionpack-5.0.3/lib/action_controller/metal/basic_implicit_render.rb:4:in send_action' /opt/rh/cfme-gemset/gems/actionpack-5.0.3/lib/abstract_controller/base.rb:188:inprocess_action' /opt/rh/cfme-gemset/gems/actionpack-5.0.3/lib/action_controller/metal/rendering.rb:30:in process_action' /opt/rh/cfme-gemset/gems/actionpack-5.0.3/lib/abstract_controller/callbacks.rb:20:inblock in process_action' /opt/rh/cfme-gemset/gems/activesupport-5.0.3/lib/active_support/callbacks.rb:126:in call' /opt/rh/cfme-gemset/gems/activesupport-5.0.3/lib/active_support/callbacks.rb:506:inblock (2 levels) in compile' /opt/rh/cfme-gemset/gems/activesupport-5.0.3/lib/active_support/callbacks.rb:455:in call' /opt/rh/cfme-gemset/gems/activesupport-5.0.3/lib/active_support/callbacks.rb:101:inrun_callbacks__' /opt/rh/cfme-gemset/gems/activesupport-5.0.3/lib/active_support/callbacks.rb:750:in _run_process_action_callbacks' /opt/rh/cfme-gemset/gems/activesupport-5.0.3/lib/active_support/callbacks.rb:90:inrun_callbacks' /opt/rh/cfme-gemset/gems/actionpack-5.0.3/lib/abstract_controller/callbacks.rb:19:in process_action' /opt/rh/cfme-gemset/gems/actionpack-5.0.3/lib/action_controller/metal/rescue.rb:20:inprocess_action' /opt/rh/cfme-gemset/gems/actionpack-5.0.3/lib/action_controller/metal/instrumentation.rb:32:in block in process_action' /opt/rh/cfme-gemset/gems/activesupport-5.0.3/lib/active_support/notifications.rb:164:inblock in instrument' /opt/rh/cfme-gemset/gems/activesupport-5.0.3/lib/active_support/notifications/instrumenter.rb:21:in instrument' /opt/rh/cfme-gemset/gems/activesupport-5.0.3/lib/active_support/notifications.rb:164:ininstrument' /opt/rh/cfme-gemset/gems/actionpack-5.0.3/lib/action_controller/metal/instrumentation.rb:30:in process_action' /opt/rh/cfme-gemset/gems/actionpack-5.0.3/lib/action_controller/metal/params_wrapper.rb:248:inprocess_action' /opt/rh/cfme-gemset/gems/activerecord-5.0.3/lib/active_record/railties/controller_runtime.rb:18:in process_action' /opt/rh/cfme-gemset/gems/actionpack-5.0.3/lib/abstract_controller/base.rb:126:inprocess' /opt/rh/cfme-gemset/gems/actionview-5.0.3/lib/action_view/rendering.rb:30:in process' /opt/rh/cfme-gemset/gems/actionpack-5.0.3/lib/action_controller/metal.rb:190:indispatch' /opt/rh/cfme-gemset/gems/actionpack-5.0.3/lib/action_controller/metal.rb:262:in dispatch' /opt/rh/cfme-gemset/gems/actionpack-5.0.3/lib/action_dispatch/routing/route_set.rb:50:indispatch' /opt/rh/cfme-gemset/gems/actionpack-5.0.3/lib/action_dispatch/routing/route_set.rb:32:in serve' /opt/rh/cfme-gemset/gems/actionpack-5.0.3/lib/action_dispatch/journey/router.rb:39:inblock in serve' /opt/rh/cfme-gemset/gems/actionpack-5.0.3/lib/action_dispatch/journey/router.rb:26:in each' /opt/rh/cfme-gemset/gems/actionpack-5.0.3/lib/action_dispatch/journey/router.rb:26:inserve' /opt/rh/cfme-gemset/gems/actionpack-5.0.3/lib/action_dispatch/routing/route_set.rb:725:in call' /opt/rh/cfme-gemset/gems/secure_headers-3.0.3/lib/secure_headers/middleware.rb:10:incall' /opt/rh/rh-ruby23/root/usr/local/share/gems/gems/rack-2.0.3/lib/rack/etag.rb:25:in call' /opt/rh/rh-ruby23/root/usr/local/share/gems/gems/rack-2.0.3/lib/rack/conditional_get.rb:38:incall' /opt/rh/rh-ruby23/root/usr/local/share/gems/gems/rack-2.0.3/lib/rack/head.rb:12:in call' /opt/rh/rh-ruby23/root/usr/local/share/gems/gems/rack-2.0.3/lib/rack/session/abstract/id.rb:232:incontext' /opt/rh/rh-ruby23/root/usr/local/share/gems/gems/rack-2.0.3/lib/rack/session/abstract/id.rb:226:in call' /opt/rh/cfme-gemset/gems/actionpack-5.0.3/lib/action_dispatch/middleware/cookies.rb:613:incall' /opt/rh/cfme-gemset/gems/actionpack-5.0.3/lib/action_dispatch/middleware/callbacks.rb:38:in block in call' /opt/rh/cfme-gemset/gems/activesupport-5.0.3/lib/active_support/callbacks.rb:97:inrun_callbacks__' /opt/rh/cfme-gemset/gems/activesupport-5.0.3/lib/active_support/callbacks.rb:750:in _run_call_callbacks' /opt/rh/cfme-gemset/gems/activesupport-5.0.3/lib/active_support/callbacks.rb:90:inrun_callbacks' /opt/rh/cfme-gemset/gems/actionpack-5.0.3/lib/action_dispatch/middleware/callbacks.rb:36:in call' /opt/rh/cfme-gemset/gems/actionpack-5.0.3/lib/action_dispatch/middleware/remote_ip.rb:79:incall' /opt/rh/cfme-gemset/gems/actionpack-5.0.3/lib/action_dispatch/middleware/debug_exceptions.rb:49:in call' /opt/rh/cfme-gemset/gems/actionpack-5.0.3/lib/action_dispatch/middleware/show_exceptions.rb:31:incall' /opt/rh/cfme-gemset/gems/railties-5.0.3/lib/rails/rack/logger.rb:36:in call_app' /opt/rh/cfme-gemset/gems/railties-5.0.3/lib/rails/rack/logger.rb:26:incall' /opt/rh/cfme-gemset/gems/request_store-1.3.2/lib/request_store/middleware.rb:9:in call' /opt/rh/cfme-gemset/gems/actionpack-5.0.3/lib/action_dispatch/middleware/request_id.rb:24:incall' /opt/rh/rh-ruby23/root/usr/local/share/gems/gems/rack-2.0.3/lib/rack/method_override.rb:22:in call' /opt/rh/rh-ruby23/root/usr/local/share/gems/gems/rack-2.0.3/lib/rack/runtime.rb:22:incall' /opt/rh/cfme-gemset/gems/activesupport-5.0.3/lib/active_support/cache/strategy/local_cache_middleware.rb:28:in call' /opt/rh/cfme-gemset/gems/actionpack-5.0.3/lib/action_dispatch/middleware/executor.rb:12:incall' /opt/rh/rh-ruby23/root/usr/local/share/gems/gems/rack-2.0.3/lib/rack/sendfile.rb:111:in call' /opt/rh/cfme-gemset/gems/railties-5.0.3/lib/rails/engine.rb:522:incall' /opt/rh/rh-ruby23/root/usr/share/gems/gems/puma-3.3.0/lib/puma/configuration.rb:224:in call' /opt/rh/rh-ruby23/root/usr/share/gems/gems/puma-3.3.0/lib/puma/server.rb:561:inhandle_request' /opt/rh/rh-ruby23/root/usr/share/gems/gems/puma-3.3.0/lib/puma/server.rb:406:in process_client' /opt/rh/rh-ruby23/root/usr/share/gems/gems/puma-3.3.0/lib/puma/server.rb:271:inblock in run' /opt/rh/rh-ruby23/root/usr/share/gems/gems/puma-3.3.0/lib/puma/thread_pool.rb:111:in `block in spawn_thread' [----] I, [2018-03-16T09:44:18.903901 #2998:13c949c] INFO -- : Rendered layouts/_exception_contents.html.haml (0.2ms) [----] I, [2018-03-16T09:44:18.904468 #2998:13c949c] INFO -- : Completed 200 OK in 56ms (Views: 1.3ms | ActiveRecord: 10.8ms)

[gaetanquentin]

and we cannot delete it either: in fact it makes a big trouble:

• when you select an imported one , the right panel is not updated. And the "Configuration menu" rely on the past selected one (not imported, a good one" . So you may think you are going to delete the imported one while you are going to delete another good one.

It could make big trouble.