rhtconsulting / puppet-jboss_admin

Puppet module for runtime configuration of a JBoss container
MIT License
15 stars 12 forks source link

Allow multiple resource-root-path declarations in module #101

Open deepfry0 opened 8 years ago

deepfry0 commented 8 years ago

In the current state, the module template and the manifest do not allow multiple resource-root-path's to be defined inside module.xml. This is a show stopper for something like db2 where you need the db2 and license jar's represented within the module.xml

<?xml version="1.0" encoding="UTF-8"?>

itewk commented 8 years ago

@deepfry0 I don't think I'm following. Can you provide more details for your use case. As an example this is what I do for a mysql.jdbc modle.

    jboss_admin::module{ 'mysql.jdbc':
      ensure        => present,
      server        => standalone,
      resource_path => "/tmp/${_mysql_driver_file}",
      dependencies  => ['javax.api',
                        'javax.transaction.api'],
    } 
deepfry0 commented 8 years ago

@itewk mysql will work because it results in the module.xml file containing a single resource_root

`

`

If you want to configure a db2 module, this is how the end module.xml should look like - `

<dependencies>
    <module name="javax.api"/>
</dependencies>

`

There are multiple resource-root tags that go into the db2 module.xml This will not work with the current code in module.pp and the erb template.

Making sense?

itewk commented 8 years ago

@deepfry0 yep. got it now. So I have two options for you

  1. patches welcome :)
  2. you can use the is_directory flag to copy all of the files from a directory and set the path as .

Option 2 is why I never got around to implementing this. But option 1 is there if you want to see it, I will be happy to review and merge.