rhtconsulting / puppet-jboss_admin

Puppet module for runtime configuration of a JBoss container
MIT License
15 stars 12 forks source link

module fails on default hornetq settings #102

Closed deepfry0 closed 8 years ago

deepfry0 commented 8 years ago

If you have hornetq configurations in the standalone instance, json parsing fails because the default remoteconnectionfactory has retry-interval-multiplier in unquoted strings

"RemoteConnectionFactory" => {
                            "auto-group" => false,
                            "block-on-acknowledge" => true,

                             "retry-interval-multiplier" => big decimal 1.0,
}

This will show up when we are trying to prefetch all cli resources

deepfry0 commented 8 years ago

This seems to be a bug introduced in the module code after September 2015. Something to do with the commits for how resources are prefetched and cached.

itewk commented 8 years ago

@deepfry0 checkout https://github.com/rhtconsulting/puppet-jboss_admin/commit/87a28f761b1585c1b56857f85b968bae6cddfca5

The fix for this will need to be in the same place. Feel up to the challenge of creating a patch and testing?

itewk commented 8 years ago

@deepfry0 and you are correct, this would have bee introduced by the code pre-fetching everything.

deepfry0 commented 8 years ago

Fix is being tested in house. Will submit a patch in the next couple of days. For reference, this is the addition to json_string - gsub(/ => big decimal/, ': ')

itewk commented 8 years ago

Merged.